Do not fail mc-admin-policy-attach if policy already attached/detached #5058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, attempts to attach a policy to a user who already has the policy attached to them results in a 400. This change is to handle cases where policy attach/detach operations are automated using scripts/jobs. A re-run of the attach/detach step should not result in the failure of the entire job.
|
Fix the lint failures |
|
Is it fine to suppress this error only in client side? Server still sends a 400 response for this and we are ignoring in client side. |
|
@shtripat , the error is being handled in mc so that the fix can work with older versions of minio servers as well. |
harshavardhana
requested changes
Oct 8, 2024
harshavardhana
requested changes
Oct 8, 2024
shtripat
approved these changes
Oct 8, 2024
harshavardhana
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
mc admin policy attachof a policy that has been already assigned to a user should succeed.Same with detach.
Motivation and Context
Currently, attempts to attach a policy to a user who already has the policy attached to them results in a 400.
This change is to handle cases where policy attach/detach operations are automated using scripts/jobs. A re-run of the attach/detach step should not result in the failure of the entire job.
How to test this PR?
Attach a policy to a user using
mc admin policy attach ...Attach the same policy again. The command should succeed.
Types of changes
Checklist:
commit-idorPR #here)